Partial Purge Support #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RPC response handling. Added new AbandonTask RPCs in orchestrator_service.proto. Updated versions.txt with latest proto file source.
YunchuWang
changed the title
…ll in PurgeResult
…methods in GrpcDurableTaskClientIntegrationTests. These tests verify the correct behavior of instance purging and ensure instances are removed as expected.
cgillum
reviewed
Mar 25, 2025
test/Client/OrchestrationServiceClientShim.Tests/ShimDurableTaskClientTests.cs
Show resolved
Hide resolved
test/Grpc.IntegrationTests/GrpcDurableTaskClientIntegrationTests.cs
Outdated
Show resolved
Hide resolved
jviau
reviewed
Mar 25, 2025
Member
jviau
left a comment
jviau
left a comment
There was a problem hiding this comment.
Please address the build warnings introduced by your changes.
jviau
reviewed
Mar 25, 2025
cgillum
approved these changes
Mar 26, 2025
halspang
pushed a commit
to halspang/durabletask-dotnet
that referenced
this pull request
Mar 26, 2025
* Enhance PurgeResult to include completion status and update related gRPC response handling. Added new AbandonTask RPCs in orchestrator_service.proto. Updated versions.txt with latest proto file source. * Update ShimDurableTaskClientTests to assert IsComplete property is not false in PurgeResult * Add end-to-end tests for PurgeInstance and PurgeInstances_WithFilter methods in GrpcDurableTaskClientIntegrationTests. These tests verify the correct behavior of instance purging and ensure instances are removed as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add portable sdk support for partial purge to dts backend. PurgeInstancesResponse will return an optional flag "Iscomplete" to indicate whether purge is fully done or done partially.
Enhancements to
PurgeResultclass and related client updates:src/Client/Core/PurgeResult.cs: Added a newisCompleteparameter to thePurgeResultconstructor and a correspondingIsCompleteproperty to indicate whether the purge operation is complete.src/Client/Grpc/GrpcDurableTaskClient.cs: Updated thePurgeInstancesCoreAsyncmethod to pass theIsCompletevalue from the response to thePurgeResultconstructor.src/Grpc/orchestrator_service.proto: Added a newisCompletefield to thePurgeInstancesResponsemessage to support the newIsCompleteproperty in thePurgeResultclass.